-
Notifications
You must be signed in to change notification settings - Fork 248
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Topic alias and message expiry support in broker #616
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mnpw
reviewed
May 19, 2023
mnpw
reviewed
May 22, 2023
h3nill
reviewed
May 22, 2023
mnpw
reviewed
May 22, 2023
h3nill
reviewed
May 23, 2023
h3nill
reviewed
May 26, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i don't really like that fact that we are deriving the fact if a particular client is a v4 or v5 from assumptions and if some variable are Some
or None
. But i think that's the best we can do with current design.
left one small comment other than that LGTM.
carlocorradini
pushed a commit
to carlocorradini/rumqtt
that referenced
this pull request
Aug 3, 2023
* feat: store properties and expiry in logs * feat: ignore expired messages * fix: checking expired messages * feat: broker handling topic alias * feat: set message expiry interval to received value minus time spent waiting * fix: case when time spent is equal to message expiry interval * feat: broker can set topic alias for clients to use * feat: send disconnet packets to client * feat: using let-else instead of if-let * feat: entry in CHANGELOG * fix: declare topic in outer scope * fix: missing argument for Link * feat: include Reason in disconnection message * feat: handle tenant prefix properly while forwarding, check max_alias explicitly * feat: make broker_topic_alias optional * feat: validate and set topic alias in separate fn * feat: comments regarding last will and storage * feat: extract all broker topic alias related things to separate struct * feat: improve readability for message expiry * feat: typos and todo * feat: ignore connack properties in v4 * feat: rename topic_alias_exists to topic_alias_already_exists
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for MQTTv5 related features, topic alias and message expiry.
Topic alias
Message Expiry
Type of change
New feature (non-breaking change which adds functionality)
Checklist:
cargo fmt
CHANGELOG.md
if its relevant of user of the library. If its not relevant mention why.